docs: correct JSDoc return value in math/base/tools/chebyshev-seriesf#11584
Merged
docs: correct JSDoc return value in math/base/tools/chebyshev-seriesf#11584
math/base/tools/chebyshev-seriesf#11584Conversation
The JSDoc example for `polyval(0.0)` with `c = [1.0, 0.5]` stated `// returns 0.5`; the Clenshaw recurrence actually yields `0.25`. https://claude.ai/code/session_01Wc7anvQg6Kbepdy1xXNMM1
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
force-pushed
the
philipp/fix-commit-review-2026-04-19
branch
from
b9b2610 to
a9b2a29
Compare
Planeshifter
changed the title
math/base/tools/chebyshev-seriesf
7 tasks
kgryte
reviewed
Apr 19, 2026
kgryte
reviewed
Apr 19, 2026
Member
|
@Planeshifter I am guessing this applies to |
kgryte
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fix for commits merged to
developbetweendcba41a4(2026-04-19 01:48 UTC) andaaa6e064(2026-04-19 12:05 UTC) — 66 first-parent commits reviewed.This pull request:
math/base/tools/chebyshev-seriesf— Fixes the// returns 0.5annotation on thepolyval( 0.0 )example inlib/factory.jsandlib/index.js(introduced in2d1c3d6); withc = [1.0, 0.5], the Clenshaw recurrence yields0.5 * (b0 - b2) = 0.25. The doctest harness missed this because its extractor regex doesn't tolerate a trailing inline comment between the;and the newline (the example carries// 1*T_0(0) + 0.5*T_1(0)after the;), so the example is skipped rather than executed.Related Issues
No.
Questions
No.
Other
Validation. Four reviewer agents (two style, two bugs) audited the 66-commit diff:
chebyshev-series,dnancount,snancount,svariance,scopy, etc.).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude (Opus 4.7) under my review: automated reviewers audited the 24h
developwindow, I triaged their findings for high signal (dropping anything subjective or requiring out-of-window scope), and applied the surviving documentation-only fix. I also manually verified the actual return value.@stdlib-js/reviewers